-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support RENAME for wildcard SELECTs #784
Conversation
Pull Request Test Coverage Report for Build 3821658894
💛 - Coveralls |
@@ -4432,7 +4440,7 @@ impl<'a> Parser<'a> { | |||
// ignore the <separator> and treat the multiple strings as | |||
// a single <literal>." | |||
Token::SingleQuotedString(s) => Ok(Some(Ident::with_quote('\'', s))), | |||
// Support for MySql dialect double qouted string, `AS "HOUR"` for example | |||
// Support for MySql dialect double quoted string, `AS "HOUR"` for example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thank you @Jefffrey
@@ -440,7 +506,7 @@ impl fmt::Display for ExcludeSelectItem { | |||
#[cfg_attr(feature = "visitor", derive(Visit))] | |||
pub struct ExceptSelectItem { | |||
/// First guaranteed column. | |||
pub fist_elemnt: Ident, | |||
pub first_element: Ident, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this fix
Closes #716
Allow RENAME for wildcard selects, for Generic and Snowflake dialects